Fix fungibles API #433
Merged
Fix fungibles API #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
Merged
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
2 times, most recently
from
c77b9ae to
6a91141
Compare
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
aec984b to
8b35dc0
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
6a91141 to
1278fab
Compare
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (01/06/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
8b35dc0 to
f6e9c8a
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
2 times, most recently
from
62e8291 to
c88d1c7
Compare
lrazovic
approved these changes
Jan 14, 2025
lrazovic
force-pushed
the
11-29-weth_oracle_support
branch
from
f6e9c8a to
ca68da1
Compare
lrazovic
force-pushed
the
12-11-fix_fungibles_api
branch
from
c88d1c7 to
42e832c
Compare
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
ca68da1 to
f6e9c8a
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
42e832c to
c88d1c7
Compare
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
f6e9c8a to
68bcca2
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
c88d1c7 to
8bcb321
Compare
JuaniRios
force-pushed
the
11-29-weth_oracle_support
branch
from
68bcca2 to
0e300ca
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
8bcb321 to
21cd51a
Compare
Merge activity
|
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
21cd51a to
c51fd70
Compare
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
c51fd70 to
43e9d12
Compare
JuaniRios
changed the base branch from
11-29-weth_oracle_support
to
graphite-base/433
JuaniRios
force-pushed
the
12-11-fix_fungibles_api
branch
from
43e9d12 to
0f183be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The fungibles API should return the universally recognized
Locationof an asset, and not where its stored locally.For example, if a parachain holds DOT in their assets pallet, the fungibles API should return the id of DOT as
(parents: 1, interior: Here), and not the internal location of the assets pallet.For this we should change the id used for foreign assets to be this universal id, and not a u32.
Why?
Testing?
In the intergration tests